Turn on the desktop native themes, and fix what turning them on exposed - #5861

Open

shai-almog wants to merge 57 commits into

desktop-native-defaults

Commits on Sep 18, 2026

Desktop keyboard conventions, and a theme constant that had no reader

shai-almog
and
claude
committed
fc732ce
Separator, GroupBox and Stepper: the three desktop controls CN1 never had

shai-almog
and
claude
committed
37a2685
Desktop themes: a real scrollbar, the surfaces CN1 still draws, and two behaviours

shai-almog
and
claude
committed
3a63f4f
A right-click menu, for the event that has always fired and never opened one

shai-almog
and
claude
committed
06194a7
commandBehavior: Native was a silent way to lose every command

shai-almog
and
claude
committed
df695c9
Every desktop port installs its platform's theme

shai-almog
and
claude
committed
8bd8dd7
Docs: restore the Desktop section COVERAGE.md lost, and record what changed

shai-almog
and
claude
committed
d8f2c63
Desktop fidelity: 9 scored controls to 22

shai-almog
and
claude
committed
a457914
Native menu bars for the Windows and Linux ports

shai-almog
and
claude
committed
bfcadc3
Scope two fidelity rows to the platforms whose references can state them

shai-almog
and
claude
committed
8f4813f
Two leaks in the new menu code, found by reading it again

shai-almog
and
claude
committed
e2c7be5
Two macOS references were in the right state and showing the wrong thing

shai-almog
and
claude
committed
8df3e66
The Fluent tab reference showed two tabs plus two close buttons

shai-almog
and
claude
committed
41c2db3
Golden sets for the second wave, from run 35370740065

shai-almog
and
claude
committed
dabad71
The GNOME capture segfaulted once in three runs

shai-almog
and
claude
committed
3779c2a
A test asserted the macOS default by its value, not by its property

shai-almog
and
claude
committed
0769d27
Framework chrome must never become an operating system window

shai-almog
and
claude
committed
d352251
The desktop themes styled two UIIDs nothing writes, so no tab looked open

shai-almog
and
claude
committed
e948c9c
WindowDialogTest stopped testing the thing it documents

shai-almog
and
claude
committed
b9cb4c7
Record what the tab fix did and did not fix

shai-almog
and
claude
committed
55442d7
The tab strip was missing the divider its platforms draw

shai-almog
and
claude
committed
41a95f6
PMD: the context menu's loop should be a foreach

shai-almog
and
claude
committed
377965a
Fidelity baselines, re-recorded from run 35379975896

shai-almog
and
claude
committed
0639c46
Linux x64 goldens for the Adwaita flip, from run 35379684156

shai-almog
and
claude
committed
971abaf
Linux arm64 goldens for the Adwaita flip, from run 35379684156

shai-almog
and
claude
committed
e3c1ff7
Windows goldens for the Fluent flip, from run 35379684087

shai-almog
and
claude
committed
5e38602
C linkage is the half of a native's identity nothing was checking

shai-almog
and
claude
committed
c03ebf4
Screenshot coverage for the desktop surface this PR turned on

shai-almog
and
claude
committed
a55ae1c
Ten animation filmstrips captured six empty cells, and the capture succeeded

shai-almog
and
claude
committed
b18490f
Register the three new screenshot tests in the port status contract

shai-almog
and
claude
committed
81bc728
Rewrap two paragraphs the desktop dialog edit left mid-phrase

shai-almog
and
claude
committed
d4c79d8
DesktopSeparator: the row COVERAGE.md already promised and the suite did not have

shai-almog
and
claude
committed
9ed0d1d
Goldens for the three new desktop tests: Linux and Windows

shai-almog
and
claude
committed
b7072ef
Goldens for the three new desktop tests: JavaScript, and DesktopMode's scrollbar

shai-almog
and
claude
committed
286a839
Map the new goldens to their tests in the port status contract

shai-almog
and
claude
committed
969ce23
Upload the Android comparison PNGs, so an Android golden can be seeded from CI

shai-almog
and
claude
committed
1a78f98
The GNOME reference segfault was a dangling widget pointer, not flakiness

shai-almog
and
claude
committed
faacb4d
Separator reference goldens for Aqua and Fluent, and drop a tile override that only moved one side

shai-almog
and
claude
committed
ad79786
Goldens for the three new desktop tests: Mac Catalyst

shai-almog
and
claude
committed
a7dd8ab
The tv and watch capture waits ended mid-stream, and blamed the tests for it

shai-almog
and
claude
committed
b887909
Goldens for the three new desktop tests: tvOS

shai-almog
and
claude
committed
74f4200
macOS goldens for the Aqua flip, from run 35395172908

shai-almog
and
claude
committed
c957f8c
Goldens for the three new desktop tests: iOS Metal and watchOS

shai-almog
and
claude
committed
6dd5d22

Commits on Sep 19, 2026

The eleventh blank filmstrip, found by the guard rather than by me

shai-almog
and
claude
committed
95e4dbd
Goldens for the three new desktop tests: Android, the set CI could not reach

shai-almog
and
claude
committed
25ea53b
Copyright header for the transition base this branch modified

shai-almog
and
claude
committed
84e0516
Catalyst's DesktopMode golden: the test stopped forcing desktop mode on itself

shai-almog
and
claude
committed
39a61c2
macOS transition goldens, now that their middle frames render

shai-almog
and
claude
committed
f90a9f3
Goldens for the three new desktop tests: iOS OpenGL, the eleventh and last set

shai-almog
and
claude
committed
4ff4d48
tvOS transition goldens: the same layout fix, a different symptom

shai-almog
and
claude
committed
f0502aa
Mac Catalyst transition goldens: the third port that had no incidental invalidation

shai-almog
and
claude
committed
63719b0
iOS Metal transition goldens, and a correction to which ports this reaches

shai-almog
and
claude
committed
093f67a
iOS OpenGL transition goldens: the lane that would only have failed after merge

shai-almog
and
claude
committed
65afb70
GNOME separator goldens, and the segfault fix confirmed on a clean capture

shai-almog
and
claude
committed
8701d4e
Merge remote-tracking branch 'origin/master' into desktop-native-defaults
shai-almog
committed
e514c96
Review round: eight findings fixed, each reproduced before it was changed

shai-almog
and
claude
committed
f7d7f37
Review round, part two: Shift on two ports, Windows accelerators, and a wait that was still wrong

shai-almog
and
claude
committed
44255c2