Skip to content

Setting: notify of failed logins only for existing accounts (codeling/bfstop#172) - #19

Merged
codeling merged 2 commits into
mainfrom
claude/gallant-babbage-ncwck1
Oct 14, 2026
Merged

codeling merged 2 commits into
mainfrom
claude/gallant-babbage-ncwck1

Conversation

@codeling

Copy link
Copy Markdown
Owner

Adds the notifyFailedOnlyExisting setting (default disabled) to the Notification tab of the settings form. The behaviour lives in the plugin: see the companion PR in codeling/bfstop for #172.

🤖 Generated with Claude Code

https://claude.ai/code/session_013HDvAhe4W1FxjobS8Etch2


Generated by Claude Code

New setting notifyFailedOnlyExisting: failed login notifications are
only sent if the entered username or email address belongs to an
existing account. Other attempts are still recorded and counted.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013HDvAhe4W1FxjobS8Etch2

Copy link
Copy Markdown
Owner Author

The only red check is Manifest, language and package checks, and it is not caused by this PR. It fails in its first step while installing libxml2-utils: E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/.../libxml2-utils_2.9.14+dfsg-1.3ubuntu3.9_amd64.deb 404 Not Found. That is a stale package index on the runner, so none of the repo's own checks ran. I re-ran the job once and it failed in about 10 seconds again, consistent with the same step. I confirmed the identical apt 404 in the first run's log; I did not open the re-run's log for this repo.

The only file changed here is admin/forms/settings.xml; I ran xmllint --noout on it locally and it is well-formed. The other 6 checks are green.

No fix exists yet. A small change in .github/workflows/ci.yml would resolve it: run sudo apt-get update before sudo apt-get install -y -q libxml2-utils. I have not added that here, to keep this PR scoped. The same failure shows on the companion PR codeling/bfstop#238.


Generated by Claude Code

@codeling
codeling merged commit e11a623 into main Oct 14, 2026
7 checks passed
@codeling
codeling deleted the claude/gallant-babbage-ncwck1 branch October 14, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants