Skip to content

Test that the unblock token only passes the unblock view #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeling merged 1 commit into from
Oct 8, 2026
Merged

Test that the unblock token only passes the unblock view #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions tests/Integration/BlockedRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,42 @@ public function testExpiredUnblockTokenIsNoPass()
$this->assertBlocked('option=com_bfstop&view=tokenunblock&token='.str_repeat('ef', 20));
}

/**
* The pass a valid token gives is for the unblock view and nothing else:
* whatever else a request carries (another task or component, in any
* spelling - Joomla matches the task case-insensitively, and the backend
* decides on the component itself - or a token which isn't a plain
* string) must still be rejected. The one request which gets through is
* the unblock view itself.
*/
public function testUnblockTokenPassIsLimitedToTheUnblockView()
{
$this->configure();
$blockId = $this->block();
$token = (new DatabaseHelper($this->logger))->getNewUnblockToken($blockId, str_repeat('ab', 20));
$this->assertBlocked('option=com_users&task=user.LOGIN&view=tokenunblock&token='.$token);
$this->assertBlocked('option=com_login&task=login&view=tokenunblock&token='.$token);
$this->assertBlocked('option=com_bfstop&task=user.login&view=tokenunblock&token='.$token);
$this->assertBlocked('option=COM_BFSTOP&view=tokenunblock&token='.$token);
$this->assertBlocked('option=com_bfstop&view=TOKENUNBLOCK&token='.$token);
$this->assertBlocked('option=com_bfstop&view=tokenunblock&token[]='.$token);
$this->assertNotBlocked('option=com_bfstop&view=tokenunblock&token='.$token);
}

/**
* A token is bound to the blocks it was issued for: a valid token of
* another address's block doesn't open the unblock view, whatever the
* request looks like otherwise.
*/
public function testUnblockTokenOfAnotherAddressIsNoPassForTheUnblockView()
{
$this->configure();
$this->block();
$otherBlockId = $this->block('203.0.113.99');
$otherToken = (new DatabaseHelper($this->logger))->getNewUnblockToken($otherBlockId, str_repeat('cd', 20));
$this->assertBlocked('option=com_bfstop&view=tokenunblock&token='.$otherToken);
}

public function testRejectedRequestsAreCounted()
{
$this->configure();
Expand Down
Loading