fix: return an empty string when readline() reaches end-of-file - #10542
Open
paulbalandan wants to merge 1 commit into
Open
fix: return an empty string when readline() reaches end-of-file#10542paulbalandan wants to merge 1 commit into
paulbalandan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
readline()returnsfalsewhen STDIN reaches end-of-file (e.g., the user presses Ctrl+D at a prompt).InputOutput::input()returned that value directly, so underdeclare(strict_types=1)it threw:The
fgets()path used when thereadlineextension is unavailable already maps EOF to''. This does the same forreadline(), so both paths behave identically.Before:
After:
The prompt is re-asked or the empty value is returned, exactly as it does today without
readline.readline()cannot be exercised under PHPUnit (the branch is skipped in thetestingenvironment and is@codeCoverageIgnored), so this was verified manually through a pty withexpecton macOS libedit.Checklist: