refactor: make BaseService and BaseCollector abstract

[samsonasik]

Description

This PR target to 4.8, change 2 files:

• system/Config/BaseService.php
• system/Debug/Toolbar/Collectors/BaseCollector.php

in the system or tests, they never instantiated, only extended, verified with structarmed ExtendedClassMustBeAbstractOrInstantiatedRule for future new Base+ prefix classes to be abstract.

->rule('base_classes.must_be_abstract', new ExtendedClassMustBeAbstractOrInstantiatedRule('Source', '/^CodeIgniter\\\\.*Base.*$/'))

applied with single command:

vendor/bin/structarmed analyze --fix

If you want to only apply the changes class change only to easier for back and forth develop and 4.8 branch, just let me know ;)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[samsonasik]

Ready for review 👍

[neznaika0]

I didn’t find a direct call to BaseConfig — should you change it as well?

[samsonasik]

That's mark as instantiated, due to new static usage as a factory process, which skipped on purpose

CodeIgniter4/system/Config/BaseConfig.php

Line 79 in 501706c

$obj = new static();

[samsonasik]

I've updated with clean up to directly filter classNamePattern in its constructor itself so no need additional layer just to filter base classes 👍

[samsonasik]

For note: I think If this merged, the structarmed.php can be backported to develop branch, then generate structarmed-baseline.php to ignore violation notice and register to baseline config as in develop branch, the base classes stil not abstract, so no need dealing with git conflict for skip the rule in develop.

[paulbalandan]

For note: I think If this merged, the structarmed.php can be backported to develop branch, then generate structarmed-baseline.php to ignore violation notice and register to baseline config as in develop branch, the base classes stil not abstract, so no need dealing with git conflict for skip the rule in develop.

If this would work, then let's have it.

[samsonasik]

@paulbalandan is it mergeable or should we wait a little bit for another opinion?

[paulbalandan]

Yes, let's merge.

[samsonasik]

Thank you @neznaika0 @michalsn @paulbalandan for the review, let's merge 👍

[samsonasik]

Ref PR to develop for backport structarmed.php to develop branch and use baseline config

• chore: Backport structarmed.php from 4.8 to develop and use baseline config #10544