Skip to content

refactor: fix phpstan errors in Result - #10473

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:result-iterable-types
Aug 23, 2026
Merged

refactor: fix phpstan errors in Result#10473
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:result-iterable-types

Conversation

@paulbalandan

@paulbalandan paulbalandan commented Aug 23, 2026

Copy link
Copy Markdown
Member

Description

  • Fixes iterable types in Result
  • Removes redundant phpdocs
  • Removes unneeded abstract methods already declared by interface

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Aug 23, 2026
@paulbalandan
paulbalandan force-pushed the result-iterable-types branch from 886aaa5 to 0dc1fca Compare August 23, 2026 18:48
@paulbalandan
paulbalandan merged commit 22a7e4e into codeigniter4:develop Aug 23, 2026
56 checks passed
@paulbalandan
paulbalandan deleted the result-iterable-types branch August 23, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes
@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @michalsn @samsonasik