Skip to content

Improve sponsor filter UX and page layout - #2821

Merged
mroderick merged 5 commits into
masterfrom
feature/sponsors-filter-ux-improvements-clean
Sep 1, 2026
Merged

Improve sponsor filter UX and page layout#2821
mroderick merged 5 commits into
masterfrom
feature/sponsors-filter-ux-improvements-clean

Conversation

@mroderick

@mroderick mroderick commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Stacked on #2820 — review and merge that PR first.

What

Improves the admin sponsors filter form and page layout.

Changes

  • Add page title (<title>) and <h1> heading
  • Add breadcrumb with link back to Admin
  • Replace raw inputs with labelled form fields in a styled fieldset
  • Add validation error when chapter name is not found
  • Style fieldset with Bootstrap border, background and rounded corners
  • Fix pagination info tag to pluralize item names correctly
  • Rename table heading from "Chapter(s)" to "Chapters"
  • Remove duplicate pagination render

Screenshot

image

Testing

  • bundle exec rspec spec/queries/sponsors_search_spec.rb
  • bundle exec rspec spec/features/admin/filtering_sponsors_list_spec.rb

@mroderick
mroderick marked this pull request as ready for review August 29, 2026 13:07
@mroderick
mroderick marked this pull request as draft August 30, 2026 07:08
@mroderick
mroderick force-pushed the feature/replace-chosen-sponsors-filter-clean branch 5 times, most recently from ddafafe to 3788be9 Compare August 30, 2026 10:34
@mroderick
mroderick force-pushed the feature/sponsors-filter-ux-improvements-clean branch from d32f0d0 to db59763 Compare August 30, 2026 16:26
Base automatically changed from feature/replace-chosen-sponsors-filter-clean to master August 31, 2026 08:30
@mroderick
mroderick force-pushed the feature/sponsors-filter-ux-improvements-clean branch from c16da44 to e4210b1 Compare August 31, 2026 21:17
@mroderick
mroderick force-pushed the feature/sponsors-filter-ux-improvements-clean branch from e98072b to 18b77ca Compare August 31, 2026 21:34
@mroderick
mroderick marked this pull request as ready for review August 31, 2026 21:40
@mroderick
mroderick requested a review from olleolleolle August 31, 2026 21:40
@mroderick
mroderick merged commit 0b3f24e into master Sep 1, 2026
10 checks passed
@mroderick
mroderick deleted the feature/sponsors-filter-ux-improvements-clean branch September 1, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants