new module structure#190
Merged
Merged
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/taurus/-/pipelines/2564395507 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14616722989/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Taurus to newer tucana / code0-flow versions and adjusts the core/provider remote-runtime integration and flow compilation to match the updated protobuf types.
Changes:
- Bump workspace dependencies:
code0-flow0.0.32 -> 0.0.33,tucana0.0.68 -> 0.0.70. - Replace
ExecutionRequestwithActionExecutionRequestthroughout the remote execution interface and request building. - Switch remote response decoding to
ActionExecutionResponseand update flow compiler/test code to the newSubFlowparameter variant (currently left unimplemented).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/taurus-provider/src/providers/remote/nats_remote_runtime.rs | Switches NATS remote decode type to ActionExecutionResponse, but currently leaves execution handling unimplemented. |
| crates/taurus-core/src/runtime/remote/mod.rs | Updates RemoteExecution to carry ActionExecutionRequest. |
| crates/taurus-core/src/runtime/engine/executor.rs | Builds ActionExecutionRequest for remote invocations. |
| crates/taurus-core/src/runtime/engine/compiler.rs | Updates parameter compilation for new SubFlow variant but currently panics via unimplemented!(). |
| crates/taurus-core/src/runtime/engine.rs | Updates test helpers for new parameter shape but currently panics via unimplemented!(). |
| Cargo.toml | Dependency bumps to pick up new module/proto structure. |
| Cargo.lock | Lockfile updates for the dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tech/taurus into #186-new-module-structure
handle test execution
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #186