Pin the Rust toolchain and scope tokio features - #40
Merged
Conversation
Gates, release builds and the image build compile with the same rustc; a floating stable moved the compiler under every job independently.
chunks_exact with a constant size becomes as_chunks; result_large_err now covers async fns, so the five async view helpers carry the same per-site allow as their sync siblings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rust-toolchain.tomlpins1.98.0instead ofstable; thedtolnay/rust-toolchain@stablesteps are gone fromci.ymlandrelease.yml, so the pin is the single source of truth for gates, release builds and therust:1image build (the same shape as sandbox's silkd/boot workflows).tokioenables only the features the workspace uses (rt-multi-thread,macros,time,sync,net,signal,io-util) instead offull;Cargo.lockdrops the one cratefullpulled in.state/avail.rssums the MGET pairs withas_chunks::<2>()(chunks_exactwith a constant size is now rejected), andresult_large_errnow covers async fns, so the five async view helpers returningResult<_, Response>carry the same per-site allow their sync siblings already had. A floatingstablewould have hit both as soon as the runners moved to 1.98.Evidence (local, arm64)
cargo fmt --all -- --check: cleancargo clippy --workspace --all-targets -- -D warnings: clean on 1.98.0cargo test --workspace: 28 suites, 548 passed, 0 failed, 3 ignored (Postgres/Redis-gated suites not run locally);gw-stateandgw-viewsre-run after the lint changesdocker build --platform linux/arm64 .: rustup inside therust:1builder synced1.98.0-aarch64-unknown-linux-gnubefore compiling, so the image no longer depends on whatrust:1floats to