Skip to content

Do not allow disabled logged-in administrators to make RPC calls via AWS. - #1717

Merged
veluca93 merged 1 commit into
cms-dev:mainfrom
veluca93:aws-disabled
Sep 15, 2026
Merged

veluca93 merged 1 commit into
cms-dev:mainfrom
veluca93:aws-disabled

Conversation

@veluca93

Copy link
Copy Markdown
Contributor

No description provided.

@veluca93
veluca93 requested a review from prandla September 15, 2026 19:18
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.65%. Comparing base (1fd66e0) to head (2be3693).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cms/server/admin/rpc_authorization.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1717   +/-   ##
=======================================
  Coverage   56.65%   56.65%           
=======================================
  Files         344      344           
  Lines       28240    28240           
=======================================
  Hits        15999    15999           
  Misses      12241    12241           
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 56.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prandla prandla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would clarify the title as "do not allow disabled administrators to make RPC calls via AWS". they already cannot use the rest of AWS.

@veluca93 veluca93 changed the title Do not allow disabled logged-in administrators to use AWS. Do not allow disabled logged-in administrators to make RPC calls via AWS. Sep 15, 2026
@veluca93
veluca93 merged commit 9964517 into cms-dev:main Sep 15, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants