Skip to content

Require auth for seeing/modifying teams. - #1716

Merged
veluca93 merged 1 commit into
cms-dev:mainfrom
veluca93:team-permissions
Sep 15, 2026
Merged

veluca93 merged 1 commit into
cms-dev:mainfrom
veluca93:team-permissions

Conversation

@veluca93

Copy link
Copy Markdown
Contributor

No description provided.

@veluca93
veluca93 requested a review from prandla September 15, 2026 18:35
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.65%. Comparing base (1ea55d2) to head (bf8f976).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cms/server/admin/handlers/user.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1716   +/-   ##
=======================================
  Coverage   56.65%   56.65%           
=======================================
  Files         344      344           
  Lines       28238    28240    +2     
=======================================
+ Hits        15998    16000    +2     
  Misses      12240    12240           
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 56.65% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prandla

prandla commented Sep 15, 2026

Copy link
Copy Markdown
Member

(minor comment: you cannot actually see teams without auth, as the jinja template throws a 500 error trying to access the nonexistent admin. but you can still blindly modify them)

@veluca93
veluca93 merged commit 1fd66e0 into cms-dev:main Sep 15, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants