[Bugfix #1436] Review artifact + thread finalization - #1464
Merged
Conversation
Review deliverable for the merged fix (PR #1451). Captures the root cause, the retry-vs-offline decision, and the lane's real lessons: a green sub-check is not a green branch (seven consecutive red heads with CLI Integration Tests green), vitest != check-types, and the .d.mts cause-fix over relocating a directive. Refs #1436
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the merged fix (PR #1451, merge commit
9fe014a95). Adds the BUGFIX review deliverable and finalizes the builder thread — the review file wasn't part of the fix PR, so it lands here. Docs only; no code.Refs #1436
Contents
codev/reviews/bugfix-1436-ci-streamdeck-validate-step-fl.md— root cause (the Elgato CLI'smanifestUrlsExistrethrows non-ENOTFOUNDfetch failures), the retry-vs-offline decision (offline ruled out empirically), and the lessons below.codev/state/bugfix-1436_thread.md— finalized with the merge saga.Lessons captured (architect-flagged)
e731e82d2…0455c7b43) whileCLI Integration Testswas green on every one — which is how "CI green" got reported/accepted on a branch that had never been fully green. Verify the whole required check set against a stationary head.pnpm test(vitest) ≠pnpm check-types(tsc). The real merge-blocker was a type error vitest ignores; run both before claiming done..d.mtssidecar leaves the test type-checkingrunWithBackoff/isTransientErrorfor real instead of importingany— a genuinely better end state than the lane was believed to be in.