Fix #1431: map verify-approval gate to view-diff in phaseArtifactVerb

[amrmelsayed]

Summary

Stream Deck's phaseArtifactVerb did not map the verify-approval gate, so a builder blocked there returned undefined and the Builder Action Automatic press fell back to opening a terminal instead of the review diff. The #1428 faces already render this gate (yellow + verified glyph + Verify label), so today the key looks gate-blocked but the press opens a terminal — a face/behaviour contradiction, the same class codex caught during #1428.

Fixes #1431

Root Cause

phaseArtifactVerb (apps/streamdeck/src/actions.ts) mapped the spec-approval, plan-approval, dev-approval, and pr gates but not verify-approval — which the VS Code sidebar's gate vocabulary already knows (gateIconFor maps it to the verified codicon). The Stream Deck resolver never caught up, so the gate returned undefined and both callers that key off it (the Builder Action Automatic press and the phase-aware dial mode) took the fallback path.

Fix

• Add verify-approval to the gate branch, returning view-diff (same as dev-approval/pr — the human is reviewing finished work). The Automatic press then resolves view-diff → open-diff-first via BuilderAction.resolveVerb (Stream Deck SD+: Automatic diff press should open the builder's first file diff (dial-ready), not the aggregate #1414), which is correct and intended.
• Add regression assertions beside the existing dev-approval/pr gate cases in actions.test.ts.
• Delete the now-stale face.ts doc-comment clause that noted the resolver did not handle this gate yet (BUGFIX Stream Deck: phaseArtifactVerb doesn't map the verify-approval gate (Automatic press falls back to terminal) #1431) — this change closes that gap.

Second behavioural effect: review dials

reviewMode() derives from the same resolver (verb === 'view-diff' → 'diff'), so this change also flips a verify-approval-blocked builder's review dials from 'none' (dead) to 'diff' (navigating the diff). This is correct and desirable — symmetric with dev-approval/pr; the dials should work while a human reviews finished work. Pinned with an added reviewMode assertion.

Test Plan

• Regression tests added — phaseArtifactVerb(verify-approval) → view-diff and reviewMode(verify-approval) → diff (both fail without the fix: phaseArtifactVerb returns undefined, reviewMode returns none)
• Build passes
• check-types clean
• All tests pass (125/125)

[amrmelsayed]

Integration review (streamdeck architect) — APPROVE. Low-risk tier, read line-by-line. The change is one clause added to an existing gate branch (verify-approval → view-diff, symmetric with dev-approval/pr — the human is reviewing finished work), its test, and deletion of the now-stale face.ts comment that pointed at this very issue as an open gap.

Board was degraded: codex was environmentally unavailable (OpenAI billing/credits, raised to the owner as an account item), so this shipped on a 2-way CMAP — gemini + claude, both APPROVE HIGH — plus architect source verification, per the interim policy both architects have adopted for low-risk lanes while the outage lasts.

That verification earned its place: the two-seat board missed a real untested behaviour change. Because reviewMode derives from phaseArtifactVerb, this mapping also flips a verify-approval-blocked builder's review dials from none (dead) to diff (navigating the diff). Correct and desirable — the dials should work exactly when a human is reviewing finished work — but unasserted. Now pinned by a regression assertion (2dfbd81) and called out in the PR body.

Closes the face/behaviour contradiction introduced by #1428's faces, which already rendered this gate as blocked (yellow + verified glyph + "Verify") while the press fell through to a terminal.