Repository navigation
fix: Always start y-axis for area chart at zero - #5125
Open
avinashbot wants to merge 1 commit into
Open
avinashbot wants to merge 1 commit into
avinashbot wants to merge 1 commit into
Conversation
avinashbot
force-pushed
the
area-chart-axis-0
branch
from
October 9, 2026 05:30
067af7f to
d104736
Compare
avinashbot
marked this pull request as ready for review
October 9, 2026 05:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5125 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 991 991
Lines 31834 31836 +2
Branches 11757 11759 +2
=======================================
+ Hits 31105 31108 +3
+ Misses 722 682 -40
- Partials 7 46 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
georgylobko
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the default baseline calculation for when a baseline isn't manually provided, so should be safe. This also gets closer to how the other (legacy) charts behave, so the different charts types are more consistent when placed next to each other.
Related links, issue #, if available: AWSUI-62336
How has this been tested?
Updated unit tests. Some permutation tests should change as well.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.