Skip to content

fix: Always start y-axis for area chart at zero - #5125

Open
avinashbot wants to merge 1 commit into
mainfrom
area-chart-axis-0
Open

avinashbot wants to merge 1 commit into
mainfrom
area-chart-axis-0

Conversation

@avinashbot

@avinashbot avinashbot commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Description

Changes the default baseline calculation for when a baseline isn't manually provided, so should be safe. This also gets closer to how the other (legacy) charts behave, so the different charts types are more consistent when placed next to each other.

Related links, issue #, if available: AWSUI-62336

How has this been tested?

Updated unit tests. Some permutation tests should change as well.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot changed the title fix: Always start y-axis baseline for area chart at 0 fix: Always start y-axis for area chart at zero Oct 9, 2026
@avinashbot
avinashbot marked this pull request as ready for review October 9, 2026 05:31
@avinashbot
avinashbot requested a review from a team as a code owner October 9, 2026 05:31
@avinashbot
avinashbot requested review from georgylobko and removed request for a team October 9, 2026 05:31
@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.71%. Comparing base (8960f56) to head (d104736).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5125   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         991      991           
  Lines       31834    31836    +2     
  Branches    11757    11759    +2     
=======================================
+ Hits        31105    31108    +3     
+ Misses        722      682   -40     
- Partials        7       46   +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

3 active deployments
dev-pages-react16 — d1047366 Deployed Oct 9, 2026 by avinashbot via deploy (React 16) / deploy #2650
dev-pages-react18 — d1047366 Deployed Oct 9, 2026 by avinashbot via deploy (React 18) / deploy #2650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants