Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5123 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 991 991
Lines 31834 31834
Branches 11757 11757
=======================================
Hits 31105 31105
Misses 722 722
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
at-susie
marked this pull request as ready for review
October 8, 2026 13:47
at-susie
requested review from
avinashbot and
jperals
and removed request for
a team and
avinashbot
October 8, 2026 13:47
jperals
reviewed
Oct 8, 2026
| */ | ||
| const tokens: StyleDictionary.ColorsDictionary = { | ||
| colorTextBodyDefault: '{colorTextNotificationDefault}', | ||
| colorTextBodyDefault: { light: '{colorNeutral800}', dark: '{colorNeutral250}' }, |
Member
There was a problem hiding this comment.
Why not leave it as colorTextNotificationDefault? They have the same values, right?
Member
Author
There was a problem hiding this comment.
You are right, my bad. Reverted the change in the notification-controls context
at-susie
enabled auto-merge
October 9, 2026 08:28
jperals
approved these changes
Oct 9, 2026
at-susie
added this pull request to the merge queue
Oct 9, 2026
Any commits made after this event will not be merged.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Flashbar text color only for one-theme.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.