Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5119 +/- ##
==========================================
- Coverage 97.71% 97.70% -0.01%
==========================================
Files 991 991
Lines 31834 31847 +13
Branches 11757 11766 +9
==========================================
+ Hits 31105 31117 +12
+ Misses 722 684 -38
- Partials 7 46 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add an icon action button to the internal ControlGroup, fused onto the grouped controls like a trailing control. The button reads the grouped-control context and owns its own border/corner fusing; the icon variant draws the shared control border. In vertical direction it sits on the inline-end spanning the full column height. The actionButton prop is a props object (ControlGroupProps.ActionButton: onClick, ariaLabel, iconName, iconAlt, disabled, disabledReason, ariaDescribedby); the component constructs the button internally. Also: reset the grouped context on Input's internal clear/close button so it does not inherit grouped sizing, and deduplicate control-group dev page fixtures into pages/control-group/common.tsx.
jperals
force-pushed
the
dev-v3-jotresse-control-group-button
branch
from
October 8, 2026 22:22
a256f34 to
5367488
Compare
jperals
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related doc:
KaCZyfbvq46DHow has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.