Public API annotations and type checking with Pyrefly#591
Open
jorenham wants to merge 6 commits intocloudpipe:masterfrom
Open
Public API annotations and type checking with Pyrefly#591jorenham wants to merge 6 commits intocloudpipe:masterfrom
jorenham wants to merge 6 commits intocloudpipe:masterfrom
Conversation
Author
|
Also, I noticed that you're still supporting Python 3.8 and 3.9, which are EOL (https://devguide.python.org/versions/). Dropping those would allow us to significantly simplify the type annotations (supporting EOL Python versions is also a bit of a security issue). So would you be open to dropping those? Because if so, then I wouldn't mind opening a PR for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went with Pyrefly here because of its speed and because it's very good at dealing with partially annotated codebases. It also helps that it comes with an LSP (unlike mypy for example), which is great for IDE integration.
Towards #541
Oh and fun fact: This increases the type coverage from 6.3% to 44.9%.