Skip to content

feat: support S3 addressing style across Barman commands - #290

Closed
davidchandra95 wants to merge 1 commit into
cloudnative-pg:mainfrom
davidchandra95:feat/s3-addressing-style
Closed

davidchandra95 wants to merge 1 commit into
cloudnative-pg:mainfrom
davidchandra95:feat/s3-addressing-style

Conversation

@davidchandra95

Copy link
Copy Markdown

Summary

Add an ObjectStore-level s3AddressingStyle setting for auto, virtual, or path. The common command builder applies it to every Barman Cloud command and overrides older command-specific addressing arguments.

Root cause

The existing additionalCommandArgs settings only reached base-backup and WAL commands. Catalog, retention, and recovery commands used the shared builder without an addressing option, so S3 services that reject path-style URLs failed after a backup completed.

Validation

  • go test ./...
  • Plugin-focused tests against this library change

Staging use

A separate draft plugin and BBGE deployment change will use this source until an upstream release is available.

Signed-off-by: david <slowtyper@davids-MacBook-Pro-2.local>
@mnencia
mnencia force-pushed the feat/s3-addressing-style branch from 773f2e2 to 761c34b Compare October 1, 2026 11:54
@mnencia

mnencia commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Closing in favor of #288, which was opened first and covers the same commands through AppendCloudProviderOptionsFromConfiguration.

Your tests are good. I ported them to #288 (precedence over additional args, restore, non-S3 rejection) and credited you with a Co-authored-by trailer. withoutOption isn't needed: the configured flag is appended last and Barman uses the last value. In the restore path, a --addressing-style=value argument is skipped when the option is already set. The space-separated form leaks the value (existing behavior of appendAdditionalCommandArgs, not new here).

For staging, you can pin the plugin to the #288 branch until a release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants