Skip to content

Improve deactivation modal styling #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielcld2 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve deactivation modal styling #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/cloudinary.css
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions php/class-deactivation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ public function render_connected() {
</div>
<?php endif; ?>
<div class="modal-body" id="modal-body">
<p>
<h2 class="cld-modal-box__title">
<?php esc_html_e( 'Before you deactivate the plugin, would you quickly give us your reason for doing so?', 'cloudinary' ); ?>
</p>
</h2>
<ul class="reasons">
<?php foreach ( $this->get_reasons() as $reason ) : ?>
<li>
Expand Down Expand Up @@ -249,7 +249,7 @@ public function render_connected() {
</p>
</div>
<div class="modal-footer" id="modal-footer">
<button class="button button-link deactivate-close" data-action="deactivate">
<button class="button deactivate-close" data-action="deactivate">
<?php esc_html_e( 'Skip and deactivate', 'cloudinary' ); ?>
</button>
<button class="button cancel-close" data-action="cancel">
Expand Down
13 changes: 5 additions & 8 deletions src/css/components/ui/_modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@
width: 500px;
max-width: 80%;

&__title {
font-size: 16px;
}

.modal-footer {
display: flex;
flex-direction: row;
Expand Down Expand Up @@ -127,9 +131,6 @@
font-size: 10.5px;
}

.button:not(.button-link) {
background-color: $color-blue-grey;
}

.button {
margin: 22px 0 0 10px;
Expand All @@ -144,13 +145,9 @@
color: $color-white;
}

&.button-link {
&.deactivate-close {
margin-left: 0;
margin-right: auto;

&:hover {
background-color: transparent;
}
}
}
}
Expand Down
Loading