Update SAML config comments to reflect correct behavior for wantAssertionSigned#3991
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the in-file uaa.yml documentation for the deprecated login.saml.wantAssertionSigned setting to reflect that it now only controls SP metadata (WantAssertionsSigned) and no longer changes SAML authentication verification/decryption behavior.
Changes:
- Reword and reflow the YAML comments describing
login.saml.wantAssertionSigneddeprecation semantics.
Comment on lines
+420
to
+422
| # Deprecated (78.13.0): only affects SP metadata WantAssertionsSigned. No longer affects authentication- | ||
| # behavior encrypted assertions are always decrypted, and authentication always requires a verifiable | ||
| # signature on the Response or on every Assertion after decryption, regardless of this setting. |
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
strehle
approved these changes
Jul 23, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.