Refactor supply and fix possible issues in frameworks - #1397
Open
kiril-keranov wants to merge 2 commits into
Open
Refactor supply and fix possible issues in frameworks#1397kiril-keranov wants to merge 2 commits into
kiril-keranov wants to merge 2 commits into
Conversation
Contributor
|
makes sense.. |
Contributor
|
Looks good, got some suggestions from my ai agent: Review suggestions1. Classpath glob: use wildcard pattern instead of enumeratingThe fix is correct, but the per-jar enumeration is inconsistent with how jarFiles, err := filepath.Glob(filepath.Join(buildDir, "*.jar"))
if err == nil && len(jarFiles) > 0 {
classpathEntries = append(classpathEntries, "$HOME/*.jar")
}Same runtime result, one classpath entry instead of N, consistent with 2. Add a unit test that catches the original bugThe existing Context("with JARs in root directory", func() {
BeforeEach(func() {
os.WriteFile(filepath.Join(buildDir, "app.jar"), []byte("fake"), 0644)
os.WriteFile(filepath.Join(buildDir, "Main.class"), []byte("fake"), 0644)
})
It("includes root JARs with $HOME prefix in classpath", func() {
os.Setenv("JAVA_MAIN_CLASS", "com.example.Main")
defer os.Unsetenv("JAVA_MAIN_CLASS")
cmd, err := container.Release()
Expect(err).NotTo(HaveOccurred())
// Verify root jars are reachable at runtime via $HOME path
Expect(cmd).To(ContainSubstring("$HOME/*.jar"))
// Or if enumerating individually:
// Expect(cmd).To(ContainSubstring("$HOME/app.jar"))
})
})This test fails on |
stokpop
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supply.goin order not to reuse already created context instead of creating new one excessively.new_relic, open_telemetry_javaagent, postgresql_jdbc, app_dynamics, jacoco_agent, spring_auto_reconfiguration, groovy, spring_boot_cli) silently fell back to a hardcoded version string whenDefaultVersionfailed a manifest lookup. This masked misconfigured or missing manifest entries, potentially installing a stale cached artifact or failing with a confusing downstream error. All eight now return a descriptive error immediately, consistent with the rest of the codebase.