Add Support for AWS-LC#925
Draft
hoffmaen wants to merge 20 commits into
Draft
Conversation
BOSH compilation VMs don't set $HOME, causing Go to fail with "build cache is required, but could not be located".
The glob 'haproxy/aws-lc-*.tar.gz' matched both aws-lc-v1.72.0.tar.gz and aws-lc-fips-3.3.0.tar.gz, causing the non-FIPS variant to include the FIPS blob and take the wrong build path. Narrowed to 'aws-lc-v*'.
Individual releases now only include the base haproxy package; multi build copies variant packages in dynamically.
ERB templates are rendered on the BOSH director where /var/vcap/packages/ doesn't exist, so File.directory? always returned false. Move the check to bash which runs on the VM at runtime.
Compiles lua, pcre2, socat, and hatop once instead of 6 times; all variant packages now depend on haproxy-deps. Version constants moved to src/haproxy-versions.sh and sourced everywhere.
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Draft RFC: https://github.com/sap-contributions/cf-community/blob/rfc-haproxy-awslc/toc/rfc/rfc-draft-haproxy-awslc.md