Repository navigation
Redact credentials in audit event request metadata - #5535
Open
philippthun wants to merge 1 commit into
Open
philippthun wants to merge 1 commit into
philippthun wants to merge 1 commit into
Conversation
Custom buildpack URLs and user-provided service instance URLs may embed credentials (user:token@host) that leaked into audit event metadata in cleartext. The app audit-event sanitizer obfuscated the legacy singular buildpack key and the v3 lifecycle.data.buildpack key, but not the v3 lifecycle.data.buildpacks array, so credentials leaked into audit.app.create and audit.app.update events. User-provided service instance events redacted the credentials hash but left syslog_drain_url and route_service_url untouched, leaking any embedded credentials into audit.user_provided_service_instance.create and .update events. Obfuscate the buildpacks array entries and the user-provided service instance URL fields with the existing URL secret obfuscator.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom buildpack URLs and user-provided service instance URLs may embed credentials (
user:token@host) that leaked into audit event metadata in cleartext.The app audit-event sanitizer obfuscated the legacy singular buildpack key and the v3 lifecycle.data.buildpack key, but not the v3 lifecycle.data.buildpacks array, so credentials leaked into
audit.app.createandaudit.app.update events.User-provided service instance events redacted the credentials hash but left
syslog_drain_urlandroute_service_urluntouched, leaking any embedded credentials intoaudit.user_provided_service_instance.createand.updateevents.Obfuscate the buildpacks array entries and the user-provided service instance URL fields with the existing URL secret obfuscator.
This change was developed with AI assistance; all code was reviewed and tested by me.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests