Repository navigation
Rewrite permission queries in domain_fetcher and route_fetcher to use UNION ALL - #5534
Open
WeiQuan0605 wants to merge 1 commit into
Open
WeiQuan0605 wants to merge 1 commit into
WeiQuan0605 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Rewrite the permission queries in DomainFetcher#fetch_all_for_orgs and RouteFetcher#fetch to use UNION ALL subqueries instead of OR predicates. Also adds space_ids_with_readable_routes_query to Permissions and passes readable_space_ids_dataset to RouteFetcher.fetch to avoid a guid→id round-trip.
An explanation of the use cases your change solves
GET /v3/domains and GET /v3/routes for non-admin users were generating correlated SubPlans in Postgres, the permission subquery was re-executed once per row in the outer result set, causing O(n²) behaviour at scale.
The UNION ALL shape builds hash tables once and eliminates the SubPlans entirely, reducing both queries to O(n).
GET /v3/domains (domain_fetcher)
Benchmarked with 20,002 orgs, 101 shared domains, 390 private domains, using EXPLAIN (ANALYZE, BUFFERS)
GET /v3/routes (route_fetcher)
Benchmarked with 5,001 spaces,10,002 routes,20,000 orgs, using EXPLAIN (ANALYZE, BUFFERS
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests