Repository navigation
Add configurable nginx client_body_timeout for uploads - #703
Open
philippthun wants to merge 1 commit into
Open
philippthun wants to merge 1 commit into
philippthun wants to merge 1 commit into
Conversation
Slow or stalling clients uploading large bits can hit nginx's built-in default client_body_timeout before the upload completes. nginx then aborts the request, which surfaces to clients as a failed upload. Add cc.nginx_client_body_timeout_for_uploads, rendered into the public upload endpoints only when set. With no value configured, no directive is emitted and nginx's default behavior is unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow or stalling clients uploading large bits can hit nginx's built-in default
client_body_timeoutbefore the upload completes. nginx then aborts the request, which surfaces to clients as a failed upload.Add
cc.nginx_client_body_timeout_for_uploads, rendered into the public upload endpoints only when set. With no value configured, no directive is emitted and nginx's default behavior is unchanged.This change was developed with AI assistance; all code was reviewed and tested by me.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite