Remove deprecated hm.syslog_event_forwarder_enabled property

[aramprice]

This property was first deprecated in 2016, time to remove it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 52753de3-20a1-485c-bb1c-cc8176a50ca0

📥 Commits

Reviewing files that changed from the base of the PR and between a723fe6 and 2ca56b3.

📒 Files selected for processing (2)

• jobs/health_monitor/spec
• jobs/health_monitor/templates/health_monitor.yml.erb

💤 Files with no reviewable changes (2)

• jobs/health_monitor/templates/health_monitor.yml.erb
• jobs/health_monitor/spec

---

Walkthrough

The hm.syslog_event_forwarder_enabled property has been removed from the health monitor job specification. The corresponding template logic that validated and processed this property has also been removed from the health_monitor.yml.erb template file. These changes eliminate the configuration option and its runtime validation checks from the health monitor job.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is severely incomplete, missing most required template sections including context, tests, release notes, breaking change analysis, and team tags.	Complete the PR description by filling all required sections: provide context (links to related issues/PRs), list tests run, write operator-focused release notes, clarify if breaking, and tag relevant team members.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: removing a deprecated property from the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-deprecated-property

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Removes the long-deprecated hm.syslog_event_forwarder_enabled Health Monitor property from the BOSH release job definition and template logic.

Changes:

• Removed the runtime template guard that raised when hm.syslog_event_forwarder_enabled was set.
• Removed the hm.syslog_event_forwarder_enabled property from the health_monitor job spec.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
jobs/health_monitor/templates/health_monitor.yml.erb	Drops the template-time check/raise related to the removed syslog forwarder property.
jobs/health_monitor/spec	Deletes the deprecated property entry from the job’s documented properties.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.