Allow generic span consumer implementations#9
Merged
Conversation
rustracing previously forced users to consume finished spans via a tokio mpsc channel. In some cases a different type of consumer is required (such as a multi-consumer queue), so we want to make this part of rustracing generic. This adds a dynamic dispatch to each `Span::drop` call, but it should be easy to predict since generally there is only a single `Tracer` per application. Adding a span into a queue for consumption is also typically much higher overhead than a dynamic dispatch. The change is intended to be backwards compatible, but adds a new trait bound to `Tracer`: `T` must be `Send + 'static`. In theory a single-threaded application would not have required this before, but in practice every implementation should fulfill these bounds.
TheJokr
force-pushed
the
lblocher/generic-consumer
branch
from
fd4604d to
9a03425
Compare
TheJokr
force-pushed
the
lblocher/generic-consumer
branch
from
9a03425 to
c58a694
Compare
fisherdarling
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustracing previously forced users to consume finished spans via a tokio
mpsc channel. In some cases a different type of consumer is required
(such as a multi-consumer queue), so we want to make this part of
rustracing generic.
This adds a dynamic dispatch to each
Span::dropcall, but it should beeasy to predict since generally there is only a single
Tracerperapplication. Adding a span into a queue for consumption is also
typically much higher overhead than a dynamic dispatch.
The change is intended to be backwards compatible, but adds a new trait
bound to
Tracer:Tmust beSend + 'static. In theory asingle-threaded application would not have required this before, but in
practice every implementation should fulfill these bounds.
Includes a release commit for
cf-rustracing 1.3.0