Conversation
Unit tests only, no library change: conditional revalidation header, Vary value in the variance key, inclusive serve-stale window end, uncacheable responses releasing waiting readers, case-insensitive request-target scheme, remove_header dropping the case-preserved name, and repeated headers surviving header-serde round trips. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1035
@andrewhavck: these are the tests from our email thread.
Tests only: seven unit tests (+123 lines) in the existing test modules. No change to library code, no new dependencies.
filters::tests::test_upstream_request_filter_revalidates_with_if_modified_sinceIf-Modified-Since, so the origin can answer 304variance::test::test_value_differentiates_keymeta::tests::test_cache_meta_serve_stale_window_end_is_inclusiveis_freshincludesfresh_untiltests::an_uncacheable_response_makes_waiting_readers_give_upauthority::tests::classify_raw_target_authority_scheme_case_insensitiveHTTP://gets the same ambiguous-authority rules ashttp://(RFC 3986 schemes are case-insensitive)tests::test_remove_header_drops_case_nametests::test_ser_de_keeps_repeated_headersHow they were checked
On a copy at 4487f7b (current
main):cargo fmt --all -- --check,cargo clippy --all-targets -p pingora-cache -p pingora-http -p pingora-header-serde -- --allow=unknown-lints --deny=warningsandcargo test --libfor those three crates all pass (193, 58 and 10 tests, including the new ones).These tests were written with Claude Code during a planted-bug run by Trenyx.