Skip to content

fix: resolve remaining Astro check hints - #32617

Open
mvvmm wants to merge 1 commit into
productionfrom
fix/astro-check-hints
Open

fix: resolve remaining Astro check hints#32617
mvvmm wants to merge 1 commit into
productionfrom
fix/astro-check-hints

Conversation

@mvvmm

@mvvmm mvvmm commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Resolves the last 5 astro check hints — now 0 errors, 0 warnings, 0 hints.

Changes

  • src/components/OneTrust.astro — Assign OptanonWrapper to window instead of declaring a local unused function. OneTrust requires it as a global callback; the assignment eliminates the TS6133 "declared but never read" hint.
  • src/components/PageHead.astro — Add is:inline to the JSON-LD <script> tag using set:html. Astro warns when set:html is used without is:inline because it cannot process the content at build time.
  • src/components/cf/CURL.astro — Replace deprecated z.string().url() with z.url() (Zod v4 API).
  • src/util/custom-loaders.ts — Replace deprecated z.string().url() with z.url() (Zod v4 API).
  • src/components/ui/search/Search.astro — Replace deprecated navigator.platform with navigator.userAgent for Apple device detection. The regex /Mac|iPhone|iPad|iPod/ matches the same substrings in userAgent.

Validation

pnpm run check              # 0 errors, 0 warnings, 0 hints
pnpm run lint               # clean
pnpm run format:core:check  # clean
pnpm run test               # 108 passed (10 files)

Checklist

  • No behavior changes intended
  • All checks pass
  • No new dependencies

- OneTrust.astro: assign OptanonWrapper to window to avoid unused warning
- PageHead.astro: add is:inline to JSON-LD script to silence implicit-inline hint
- CURL.astro: replace deprecated z.string().url() with z.url()
- custom-loaders.ts: replace deprecated z.string().url() with z.url()
- Search.astro: replace deprecated navigator.platform with navigator.userAgent
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
*.astro @cloudflare/content-engineering, @kodster28
/src/components/ui/search/ @cloudflare/content-engineering, @cloudflare/ai-search
*.ts @cloudflare/content-engineering, @kodster28

@mvvmm
mvvmm marked this pull request as ready for review August 7, 2026 20:40
@mvvmm
mvvmm requested review from a team and kodster28 as code owners August 7, 2026 20:40
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No issues found in commit 029029e.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants