fix(ai-gateway-provider): isolate per-request fetch via Proxy - #635
Open
edenbuilds wants to merge 3 commits into
Open
fix(ai-gateway-provider): isolate per-request fetch via Proxy#635edenbuilds wants to merge 3 commits into
edenbuilds wants to merge 3 commits into
Conversation
processModelRequest mutated shared model.config.fetch for both capture and response replay. Concurrent calls on one gateway-wrapped model cross-wired bodies/responses. Use a Proxy so each call gets its own fetch without mutating the shared model. Fixes cloudflare#620
🦋 Changeset detectedLatest commit: 8bc6132 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Required so the concurrent-fetch Proxy fix bumps @cloudflare/ai-gateway-provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processModelRequestmutated sharedmodel.config.fetchwhen capturing provider requests and when replaying the gateway response.generateTextcalls on one gateway-wrapped model could cross-wire bodies/responses (one caller sawANSWER:undefined, the other got the wrong prompt).config.fetchper call instead of mutating the shared config.Test plan
generateTextisolation regression (issue reproduction)ANSWER:undefinedcross-wire)Fixes #620
Made with Cursor