Fix extra_capabilities not being split and trim comma-separated lists#424
Open
kallioli wants to merge 1 commit into
Open
Fix extra_capabilities not being split and trim comma-separated lists#424kallioli wants to merge 1 commit into
kallioli wants to merge 1 commit into
Conversation
extra_capabilities was passed to Add-CapabilitiesToImage as a single raw string instead of an array, so DISM received one bogus /CapabilityName:"A,B" argument and failed (e.g. OpenSSH.Server,OpenSSH.Client on Windows Server 2025). Add a ConvertFrom-CommaSeparatedString helper that splits on commas, trims whitespace around each entry and drops empty entries, and use it for extra_features, extra_packages and extra_capabilities. This also fixes whitespace-padded values (e.g. "A, B") that previously broke DISM, and tolerates trailing commas. Add unit tests for the new helper. Closes: cloudbase#422
kallioli
force-pushed
the
fix/extra-features-capabilities-split
branch
from
6afac20 to
efdb418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extra_capabilities was passed to Add-CapabilitiesToImage as a single raw string instead of an array, so DISM received one bogus /CapabilityName:"A,B" argument and failed (e.g. OpenSSH.Server,OpenSSH.Client on Windows Server 2025).
Add a ConvertFrom-CommaSeparatedString helper that splits on commas, trims whitespace around each entry and drops empty entries, and use it for extra_features, extra_packages and extra_capabilities. This also fixes whitespace-padded values (e.g. "A, B") that previously broke DISM, and tolerates trailing commas.
Add unit tests for the new helper.
Closes: #422