Conversation
Match the startup query's positive workflow job ID filter in the watcher. Scale-set jobs otherwise enter the pool queue and repeatedly fail label matching when their request labels are empty. Signed-off-by: Adam Harwell <flux.adam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scale-set jobs reach the pool manager through database watcher events, even without webhooks. The startup query already filters on
workflow_job_id > 0, but the watcher caches every non-completed job belonging to the entity. As a result, queued scale-set jobs are incorrectly considered for pool allocation.For scale-set workflows using
runs-on: group:without labels, each pool reconciliation logserror finding pools matching labels: missing tags. Scale-set jobs with labels also enter the pool-matching path, despite belonging to the scale-set worker.Apply the same positive workflow-job-ID check to incoming watcher events. This leaves normal webhook handling unchanged and does not mask empty-label errors for webhook jobs. No database changes or dependencies on other PRs.
Tests
GOWORK=off go test -race -mod=vendor -tags testing -timeout=15m -parallel=4 -count=1 ./...--build-tags=testing,integration; formatting andgit diff --check.