Add a method to know if providers support or not shared disks in clustered transfers#476
Merged
Merged
Conversation
fabi200123
force-pushed
the
shared-disks-check
branch
from
July 22, 2026 10:43
d02554d to
d0b54ec
Compare
| Destination import providers that can attach the same volume to | ||
| multiple instances (e.g. Libvirt ``<shareable/>``) should override | ||
| this to return ``True``. Defaults to ``False``. | ||
| """ |
Member
There was a problem hiding this comment.
I'd also add the following since the ability to attach the volumes to multiple instances isn't all that's required on the provider side.
In order to coordinate shared disk operations, the conductor will mark one of the instances
as owner of the shared disk.
As such, operations such as disk creation, deletion, resize or data migration should be handled
by tasks that are targeting the owner instance.
fabi200123
force-pushed
the
shared-disks-check
branch
from
July 22, 2026 13:10
d0b54ec to
bead71f
Compare
petrutlucian94
approved these changes
Jul 22, 2026
Dany9966
reviewed
Jul 24, 2026
| if not destination_provider.supports_shared_disks(): | ||
| raise exception.NotSupportedOperation( | ||
| operation=( | ||
| "Destination platform '%s' does not support shared " |
Contributor
There was a problem hiding this comment.
Please mention that the Destination platform {destination_type} does not support synchronized transfer of instances that have shared disks.
fabi200123
force-pushed
the
shared-disks-check
branch
from
July 24, 2026 14:32
bead71f to
d5e1516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
supports_shared_disks) to know if they have implemented the support for shared disks or not