Repository navigation
Conversation
Clojure allows an alias like utils.strings, but the slash only counted after a token without dots, so that no namespace name (clojure.string/) would trigger a lookup. The two read the same, though. A token with dots now counts as long as no segment is capitalized, which still rules out a class name. A namespace name goes through the lookup but finds nothing, as the REPL skips the names of loaded namespaces and nothing in the project uses one as an alias.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slash after a dotted token never counted, which left out aliases like
utils.strings. A namespace name such asclojure.stringreads the same, so it now goes through the lookup too and comes back empty. That's a quick round trip, since the REPL checks for a loaded namespace first.Fixes #4221