Skip to content

Fix environment - #5961

Open
coolreader18 wants to merge 11 commits into
masterfrom
noa/fix-environment
Open

Fix environment#5961
coolreader18 wants to merge 11 commits into
masterfrom
noa/fix-environment

Conversation

@coolreader18

@coolreader18 coolreader18 commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of Changes

  • Changes the publish payload from a json object with a base64-encoded module back to just a module, with the environment variables being sent in headers.
  • Splits out environment-only publishing into its own endpoints and codepaths.
  • Stops treating the presence of an empty Environment ModuleDef section as meaningful.
  • Cleans up a whole bunch of weird stuff from Implement persistent typed database environments #5887

API and ABI breaking changes

yes, but it's not been released

Rollback safety impact

n/a

Expected complexity level and risk

2

Testing

  • The unittests are pretty thorough, and in general I didn't really change behavior besides the http API, so I'm pretty confident they'll be sufficient.

@coolreader18
coolreader18 marked this pull request as ready for review September 23, 2026 23:03
@coolreader18
coolreader18 force-pushed the noa/fix-environment branch 2 times, most recently from 14ef545 to 8b16ff1 Compare September 24, 2026 17:16
@coolreader18
coolreader18 changed the base branch from master to noa/upd-rust-1.98 September 24, 2026 17:18
@coolreader18
coolreader18 added this pull request to stack #5982 September 24, 2026 17:23
@coolreader18
coolreader18 force-pushed the noa/fix-environment branch 3 times, most recently from dfa2b9b to 3763649 Compare September 24, 2026 18:58
Base automatically changed from noa/upd-rust-1.98 to master September 24, 2026 23:03
@coolreader18
coolreader18 force-pushed the noa/fix-environment branch 3 times, most recently from 8aee3f6 to 00dd547 Compare September 25, 2026 03:56
Shubham8287
Shubham8287 reviewed Sep 25, 2026
View reviewed changes
Comment thread crates/cli/src/subcommands/publish/environment.rs
Shubham8287
Shubham8287 reviewed Sep 25, 2026
View reviewed changes
Comment thread crates/client-api/src/routes/database.rs Outdated
Shubham8287
Shubham8287 reviewed Sep 25, 2026
View reviewed changes

@Shubham8287 Shubham8287 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think failing smoketest are still relevant and should be looked.

@coolreader18
coolreader18 force-pushed the noa/fix-environment branch 2 times, most recently from 55de577 to 8610564 Compare September 25, 2026 18:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shubham8287 Shubham8287 Shubham8287 left review comments
@bfops bfops Awaiting requested review from bfops
@jdetter jdetter Awaiting requested review from jdetter
@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler
@rekhoff rekhoff Awaiting requested review from rekhoff

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coolreader18 @Shubham8287