Render arrays correctly in SQL#5377
Open
clockwork-labs-bot wants to merge 1 commit into
Open
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #4825.
Reimplements the array SQL rendering fix from stale PR #3945 on current
master.The change adds a typed array serialization hook so SQL formatters can render arrays as one value instead of streaming each element independently.
spacetime sqlnow renders non-byte arrays with array delimiters, whilearray<u8>keeps the existing byte output. The PostgreSQL row encoder now emits primitive arrays as native PG arrays and nested/complex arrays as JSON array fields.API and ABI breaking changes
None.
Expected complexity level and risk
This touches shared SATS formatting, but the new hook preserves the previous default array serialization path and is only overridden by SQL-specific formatters.
Testing
RUSTC=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/rustc /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo test -p spacetimedb-cli output_arrays --libLC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 RUSTC=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/rustc /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo test -p spacetimedb-pg encoder::tests --libLC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 RUSTC=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/rustc /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo test -p spacetimedb-sats --libgit diff --check