Skip to content

hotfix/cp-12810-push-notification-toggle-malfunction-in-android-test-app - #390

Open
unnaticleverpush wants to merge 2 commits into
masterfrom
hotfix/cp-12810-push-notification-toggle-malfunction-in-android-test-app
Open

unnaticleverpush wants to merge 2 commits into
masterfrom
hotfix/cp-12810-push-notification-toggle-malfunction-in-android-test-app

Conversation

@unnaticleverpush

@unnaticleverpush unnaticleverpush commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Fix parent and subtopic checkbox synchronization in topics dialog


Note

Medium Risk
Changes subscription topic selection UI and in-memory selectedTopics before save; incorrect sync could mis-target push topics but scope is limited to the topics dialog.

Overview
Fixes parent/subtopic checkbox behavior in the Android topics dialog (setupTopicChildCheckboxes).

Child rows are built in one indented layout with tracked checkbox lists. Re-entrant listener guards stop parent and child OnCheckedChangeListener callbacks from looping when one side updates the other.

Parent checked toggles all children in the UI, keeps selectedTopics in sync (including when child listeners are skipped), shows/hides the child group, and refreshes bulk Select/Remove buttons after children change.

Child checked updates that subtopic and checks the parent without unchecking the parent when a child is cleared; the parent id is added to selectedTopics when the parent listener is suppressed.

Previously, child layout setup ran inside the loop and parent/child state could diverge on save.

Reviewed by Cursor Bugbot for commit 9906be9. Bugbot is set up for automated code reviews on this repo. Configure here.

`Fix parent and subtopic checkbox synchronization in topics dialog`
@unnaticleverpush unnaticleverpush self-assigned this Oct 26, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 79aa893. Configure here.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants