Repository navigation
hotfix/cp-12810-push-notification-toggle-malfunction-in-android-test-app - #390
Open
unnaticleverpush wants to merge 2 commits into
Open
unnaticleverpush wants to merge 2 commits into
unnaticleverpush wants to merge 2 commits into
Conversation
`Fix parent and subtopic checkbox synchronization in topics dialog`
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 79aa893. Configure here.
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
unnaticleverpush
requested review from
akshay-g-jadhav,
divocp,
namdev-jagtap and
snuricp
October 26, 2026 17:59
namdev-jagtap
approved these changes
Oct 27, 2026
divocp
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix parent and subtopic checkbox synchronization in topics dialog
Note
Medium Risk
Changes subscription topic selection UI and in-memory
selectedTopicsbefore save; incorrect sync could mis-target push topics but scope is limited to the topics dialog.Overview
Fixes parent/subtopic checkbox behavior in the Android topics dialog (
setupTopicChildCheckboxes).Child rows are built in one indented layout with tracked checkbox lists. Re-entrant listener guards stop parent and child
OnCheckedChangeListenercallbacks from looping when one side updates the other.Parent checked toggles all children in the UI, keeps
selectedTopicsin sync (including when child listeners are skipped), shows/hides the child group, and refreshes bulk Select/Remove buttons after children change.Child checked updates that subtopic and checks the parent without unchecking the parent when a child is cleared; the parent id is added to
selectedTopicswhen the parent listener is suppressed.Previously, child layout setup ran inside the loop and parent/child state could diverge on save.
Reviewed by Cursor Bugbot for commit 9906be9. Bugbot is set up for automated code reviews on this repo. Configure here.