Repository navigation
hotfix/cp-12815-preserve-attributes-tags-and-subscription-history-when-user-re-enables-notifications - #389
Open
unnaticleverpush wants to merge 2 commits into
Conversation
…n-user-re-enables-notifications Preserve subscription data when notifications are disabled and re-enabled
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
unnaticleverpush
requested review from
akshay-g-jadhav,
divocp,
namdev-jagtap and
snuricp
October 23, 2026 14:16
…n-user-re-enables-notifications PR changes
namdev-jagtap
approved these changes
Oct 26, 2026
divocp
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve subscription data when notifications are disabled and re-enabled
Note
Medium Risk
Changes unsubscribe cleanup and subscription sync payload affect targeting and server-side subscription state when notifications are toggled.
Overview
When users unsubscribe with
keepTargetingDataOnUnsubscribeenabled, Piano segments are now kept in local prefs alongside topics, tags, and attributes—they are only cleared when that flag is off.Subscription sync (
/subscription/sync/) now reads stored tags and custom attributes fromSharedPreferencesand includes them in the sync payload (tags,customAttributes), so re-enabling notifications can restore targeting data on the server without losing local history.Reviewed by Cursor Bugbot for commit dbbf36f. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Preserves subscription data when users disable and re-enable notifications.
keepTargetingDataOnUnsubscribeis enabled.Written for commit dbbf36f. Summary will update on new commits.