Skip to content

test(ui): raise the vitest per-test timeout to 15s - #9740

Closed
wobsoriano wants to merge 1 commit into
mainfrom
rob/ui-vitest-timeout
Closed

test(ui): raise the vitest per-test timeout to 15s#9740
wobsoriano wants to merge 1 commit into
mainfrom
rob/ui-vitest-timeout

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

The Unit Tests job has been failing across PRs with Error: Test timed out in 5000ms in @clerk/ui. The test that dies rotates between runs (OrganizationSecurityPage, Checkout, MfaTOTPScreen, phone-input, the add-phone controller), so no single test is at fault. The job runs turbo test for every package at once on an 8-core runner, and the package's heaviest userEvent dialog tests cross a 5s budget under that contention. The suite also grew from 233 to 245 test files this week.

This change raises testTimeout in the @clerk/ui vitest config to 15s. No test or product code changes.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

CI runs every package's vitest at once on an 8-core runner, and the
heaviest @clerk/ui dialog tests routinely cross the 5s default under
that contention. The timed-out test rotates between runs, so the budget
is the flake, not any one test.
@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 11, 2026 8:23pm UTC
swingset Ready Ready Preview Sep 11, 2026 8:23pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 227050b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 24ea7b5e-0f96-4bc5-bbc4-95df2b64f81a

📥 Commits

Reviewing files that changed from the base of the PR and between c44a814 and 227050b.

📒 Files selected for processing (2)
  • .changeset/ui-vitest-timeout.md
  • packages/ui/vitest.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)

Included review availability: 7 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The UI Vitest testTimeout increases from 5,000 milliseconds to 15,000 milliseconds. A Changesets metadata file with empty frontmatter is added.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 22705

This configuration-only change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: increasing the UI Vitest per-test timeout to 15 seconds.
Description check ✅ Passed The description explains the timeout failures, the cause, the configuration change, and the scope of the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed clerk/clerk_go, clerk/dashboard, clerk/accounts, clerk/backoffice, clerk/clerk, skipped clerk/clerk-docs, clerk/cloudflare-workers.


Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9740

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9740

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9740

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9740

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9740

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9740

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9740

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9740

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9740

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9740

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9740

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9740

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9740

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9740

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9740

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9740

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9740

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9740

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9740

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9740

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9740

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9740

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9740

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9740

commit: 227050b

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-11T20:25:16.325Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 227050b.

@wobsoriano wobsoriano closed this Sep 11, 2026
@wobsoriano
wobsoriano deleted the rob/ui-vitest-timeout branch September 11, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant