test(ui): raise the vitest per-test timeout to 15s - #9740
Conversation
CI runs every package's vitest at once on an 8-core runner, and the heaviest @clerk/ui dialog tests routinely cross the 5s default under that contention. The timed-out test rotates between runs, so the budget is the flake, not any one test.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 227050b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 7 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe UI Vitest Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This configuration-only change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
Description
The Unit Tests job has been failing across PRs with
Error: Test timed out in 5000msin@clerk/ui. The test that dies rotates between runs (OrganizationSecurityPage, Checkout, MfaTOTPScreen, phone-input, the add-phone controller), so no single test is at fault. The job runsturbo testfor every package at once on an 8-core runner, and the package's heaviestuserEventdialog tests cross a 5s budget under that contention. The suite also grew from 233 to 245 test files this week.This change raises
testTimeoutin the@clerk/uivitest config to 15s. No test or product code changes.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change