feat(ui): list every enterprise connection and scope the SSO wizard to one - #9729
Draft
NicolasLopes7 wants to merge 3 commits into
Draft
feat(ui): list every enterprise connection and scope the SSO wizard to one#9729NicolasLopes7 wants to merge 3 commits into
NicolasLopes7 wants to merge 3 commits into
Conversation
FAPI returns the organization's enterprise connections unordered. Every reader now sorts by createdAt, then id, so "the first connection" means the same connection on every render and in every host.
The Security page renders one row per enterprise connection with its own status badge, domains, and actions, plus an Add connection button. The wizard edits an explicit connection scope (new or an existing id) instead of the first item in the list, shows a banner naming that connection when the organization has more than one, and changeProvider takes the id of the connection it replaces. Reset, remove, and change-provider dialogs name the connection they act on.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9b6d138 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Frontend half of allowing more than one enterprise connection per organization. Today
<ConfigureSSO>and the organization Security page readenterpriseConnections[0], and FAPI returns that list unordered. With two connections the wizard edits an arbitrary one, and "Change provider" deletes an arbitrary one together with its SCIM directory.What changes for someone using the components:
{ kind: 'new' } | { kind: 'existing', id }, owned byuseOrganizationEnterpriseConnection, and set by the Security page before it opens the wizard. Creating a connection moves the scope to the created one, and removing the scoped connection pins the scope tonewso the wizard never silently reseats onto a connection the user did not pick.changeProvider(id, provider)takes the id of the connection it replaces. The change-provider, reset, and remove dialogs name the connection they act on.createdAtthenid, so the standalone<ConfigureSSO>mount and the Directory Sync section, which still use the first connection, agree on which one that is.Out of scope, left for follow-ups:
New localization keys live under
configureSSO.connectionScopeBannerandorganizationProfile.securityPage.ssoSectioninen-USonly.domainLabeland theorganizationProfileSecuritySsoDetailRowLabeldescriptor are no longer rendered but stay in place since they are public appearance API.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change