Skip to content

fix(deploy): read unsupported_features from the 402 plan error meta - #477

Open
djgould wants to merge 1 commit into
mainfrom
fix/deploy-plan-unsupported-features
Open

djgould wants to merge 1 commit into
mainfrom
fix/deploy-plan-unsupported-features

Conversation

@djgould

@djgould djgould commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

clerk deploy now lists the features your plan doesn't cover on a 402 unsupported_subscription_plan_features error.

  • readFeatures() read meta.features, but PLAPI emits meta.unsupported_features (matching the global handler in cli-program.ts), so the message always fell back to the generic text.
  • Adds errors.test.ts covering the listed-features and empty-list cases, plus a patch changeset.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: b061f787-dbe6-44d3-8b62-16f8961c20ce

📥 Commits

Reviewing files that changed from the base of the PR and between 57b9163 and a6a263f.

📒 Files selected for processing (3)
  • .changeset/deploy-plan-unsupported-features.md
  • packages/cli-core/src/commands/deploy/errors.test.ts
  • packages/cli-core/src/commands/deploy/errors.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The deploy error mapper now reads unsupported feature names from meta.unsupported_features. Tests cover feature listing and fallback messaging when the list is empty. A patch changeset documents the updated deployment error reporting.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a6a26

Deploy plan errors now report unsupported features returned by the Platform API, with a fallback message when none are listed. The change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the deploy error fix: reading unsupported_features from the 402 plan error metadata.
Description check ✅ Passed The description accurately explains the metadata field correction, user-visible behavior, tests, and changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Warning

Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed clerk/clerk_go, clerk/dashboard, clerk/accounts, clerk/backoffice, clerk/clerk, skipped clerk/clerk-docs, clerk/cloudflare-workers.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant