[release-14.0] Quote EXTRACT fields in PG16-18 ruleutils - #8809
Merged
ibrahim halatci (ihalatci) merged 4 commits intoAug 28, 2026
Merged
ibrahim halatci (ihalatci) merged 4 commits into
ibrahim halatci (ihalatci) merged 4 commits into
Conversation
Match PostgreSQL's CVE-2026-15741 stable-branch fix by quoting EXTRACT field identifiers in the copied ruleutils implementations. Add version-specific, repeat-safe regression coverage that verifies statement-like field text cannot escape the deparsed expression. Fixes #8803 Backport of #8804 (cherry picked from commit 13729d8) (cherry picked from commit d4bf1ce) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-14.0 #8809 +/- ##
================================================
- Coverage 88.57% 88.54% -0.03%
================================================
Files 289 289
Lines 64585 64584 -1
Branches 8121 8120 -1
================================================
- Hits 57208 57189 -19
- Misses 5028 5049 +21
+ Partials 2349 2346 -3 🚀 New features to boost your workflow:
|
Consolidate the PG16-18 regression into one shared, repeat-safe test in the N-1-excluded create-Citus schedule. This preserves supported-major coverage without expecting the pre-fix 14.2 coordinator library to pass the new assertion. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the shared main-branch regression test verbatim so release jobs exercise identical repeat-safe output while retaining release-14's N-1 schedule isolation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The release regression harness does not echo the blank lines preserved by main. Keep the shared SQL identical while using the proven release expected output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ibrahim halatci (ihalatci)
merged commit Aug 28, 2026
5b1bc79
into
release-14.0
184 of 217 checks passed
ibrahim halatci (ihalatci)
deleted the
ihalatci-release-14-extract-quoting
branch
August 28, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport the focused EXTRACT identifier quoting parity fix from #8804 to
release-14.0for PostgreSQL 16, 17, and 18.ruleutilsimplementationsextract_deparseregression covering every supported PostgreSQL majormulti_1_create_citus_schedule, outside the 14.2 N-1 mixed-library matrixFixes #8803.
Main PR: #8804
Validation
extract_deparsetest passed focused PG16 validation; identical shared SQL/expected output is scheduled for PG16-18release-14.0and did not touch EXTRACT outputgit diff --checkpassedCI triage
All current-version, feature, packaging, style, snapshot, and relevant N-1 checks pass. The remaining
Test Citus Lib N-1 / PG18 - check-multifailure and all 32Test flakynessfailures match unmodifiedrelease-14.0baseline run https://github.com/citusdata/citus/actions/runs/32951765361. The N-1 failure is unrelatedmulti_insert_selectAIO DEBUG output; the flakiness gate runs broad release-vs-main history and fails pre-existing tests.codecov/projectis downstream of those baseline failures.