Skip to content

fix(microbot): error telemetry follow-ups from release review #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsami merged 2 commits into from
Oct 9, 2026
Merged

fix(microbot): error telemetry follow-ups from release review #1902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e3efc
fix(microbot): requeue error batch when submit throws; close response…
chsami Oct 7, 2026
e63a524
Merge remote-tracking branch 'origin/development' into review-1902
chsami Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,14 @@ public void onFailure(Call call, IOException e)
@Override
public void onResponse(Call call, Response response)
{
if (!response.isSuccessful())
boolean successful = response.isSuccessful();
int code = response.code();
response.close();
if (!successful)
{
log.debug("Error telemetry upload rejected: HTTP {}", response.code());
log.debug("Error telemetry upload rejected: HTTP {}", code);
onRejected.run();
}
response.close();
}
});
}
Expand Down
10 changes: 9 additions & 1 deletion ...t/src/main/java/net/runelite/client/plugins/microbot/diagnostics/ScriptErrorReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,15 @@ private void send()
payload.addProperty("osName", System.getProperty("os.name"));
payload.addProperty("osArch", System.getProperty("os.arch"));
payload.add("errors", errors);
microbotApi.submitErrors(payload, () -> requeue(errors));
try
{
microbotApi.submitErrors(payload, () -> requeue(errors));
}
catch (RuntimeException e)
{
requeue(errors);
throw e;
}
}

public void rememberPlayerName(String name)
Expand Down
9 changes: 9 additions & 0 deletions ...c/test/java/net/runelite/client/plugins/microbot/diagnostics/ScriptErrorReporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,15 @@ public void requeuesRejectedBatch()
assertEquals(2, captor.getValue().getAsJsonArray("errors").get(0).getAsJsonObject().get("count").getAsInt());
}

@Test
public void requeuesBatchWhenSubmitThrows()
{
org.mockito.Mockito.doThrow(new IllegalArgumentException("bad url")).when(api).submitErrors(any(), any());
log(Level.ERROR, "loop failed", boom());
reporter.flush();
assertEquals(1, reporter.pendingCount());
}

@Test
public void groupsMessagesThatOnlyDifferInNumbers()
{
Expand Down
Loading