Repository navigation
Config key rx_dma: receive by interrupt where the DMA does not serve the UART - #9
Merged
Merged
Conversation
…the UART The DMA receive added in the previous change cannot work on a platform whose DMA controller is not driven by the UART - Renode's STM32F7 model has no request line from the USART, so a console UART received nothing there. `rx_dma=0` of the UART's section makes the instance receive by interrupt (dmuart_port_set_rx_dma(), called before set_rx_ring(); the default stays DMA). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DMA receive of #8 cannot work where the DMA is not driven by the UART: Renode's STM32F7 USART has no request line to the DMA, so a console UART received nothing there and dmod-boot's Renode tests fail.
New key
rx_dmaof the UART's section (default 1):rx_dma=0makes the instance receive by interrupt. It goes through a new port function,dmuart_port_set_rx_dma(), called beforedmuart_port_set_rx_ring(); the STM32F7 port takes it into account, the STM32F4 port (interrupt only) accepts it. Documented indocs/configuration.md.This is a minor change of the port's interface: release it as a new minor version (1.2 or higher).
Testing
Builds for
arch/armv7/cortex-m7. Not run on the board or in Renode: the default (DMA) is the code path of #8, which was tested on the STM32F746G-DISCO. dmod-boot uses the key in choco-technologies/dmod-boot (Emulation: the UARTs receive by interrupt).🤖 Generated with Claude Code