test(mobile): allow a subpixel overlap when the macro builder field scrolls into view

[chhoumann]

The new phone-keyboard spec from #2133 failed on the Linux e2e runner (full run and alone): after keyboardDidShow, the macro builder's script field ends at 378.28 px and the footer starts at 378 px. scrollIntoView did its job; the scroll position is whole pixels at 1x, so 0.28 px of the field's bottom stays under the footer. On the Mac where the spec was written (2x), it lines up exactly.

The check now allows 1 px. Before the scroll the field is 197 px under the footer, so the spec still fails without the fix. Test-only; phone-keyboard.test.ts passes 3/3 here.

Note

Allow 1px subpixel overlap in phone keyboard footer-coverage e2e test

Relaxes the footer-coverage predicate in phone-keyboard.test.ts so the macro builder field counts as covered only when its bottom exceeds the footer top by more than one pixel. A comment documents that the tolerance handles fractional scroll positioning. Test-only change; no product behavior is affected.

^{Macroscope summarized b3296dc.}

Summary by CodeRabbit

• Tests
  • Updated the keyboard coverage check to ignore overlaps of one pixel or less.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-02T08:58:43.475659Z	b3296dc	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f6918548-17d8-4b5c-b0a8-f9ff3d78a0fd

📥 Commits

Reviewing files that changed from the base of the PR and between 384ab9a and b3296dc.

📒 Files selected for processing (1)

• tests/e2e/phone-keyboard.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The macro-builder keyboard test now considers the field covered only when its bottom extends more than one pixel past the footer’s top.

Changes

Keyboard Coverage Check

Layer / File(s)	Summary
Field coverage assertion tests/e2e/phone-keyboard.test.ts	The coverage check now requires the field’s bottom to extend more than one pixel past the footer’s top.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b3296

The test retains its check that the keyboard scrolls the field clear of the footer while tolerating the intended one-pixel alignment difference. No actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to b3296

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in tests/e2e/phone-keyboard.test.ts: The coverage check now requires the field’s bottom to extend more than one pixel below the footer’s top; previously, any overlap counted as coverage.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the test change and its purpose: allowing a small overlap when the macro builder field scrolls into view on mobile.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the footer’s line
One pixel marks the field’s decline
The keyboard test now draws it clear
A careful check, a threshold near
I nibble greens and hop away!}

_{Comment @coderabbitai help to get the list of available commands.}