fix(macro): ignore Add with nothing chosen in the macro builder

src/gui/MacroGUIs/CommandSequenceEditor.audit-macro.test.ts

@@ -111,6 +111,40 @@ describe("CommandSequenceEditor silent-add feedback", () => {
 		editor.destroy();
 	});
 
+	// #2122: the first-macro walkthrough says "Add an Editor commands entry and
+	// choose ...", so Add is often clicked before anything is chosen.
+	it("does nothing when Add is clicked with nothing chosen", async () => {
+		const logError = vi.spyOn(log, "logError").mockImplementation(() => {});
+		const onCommandsChange = vi.fn();
+		const editor = new CommandSequenceEditor({
+			app: testApp(),
+			plugin: { settings: { choices: [] } } as unknown as QuickAdd,
+			commands: [],
+			choices: [],
+			onCommandsChange,
+		});
+		const container = document.createElement("div");
+		document.body.appendChild(container);
+		editor.render(container);
+
+		const editorCommands = container.querySelector("select");
+		if (!editorCommands) throw new Error("Editor commands dropdown not found");
+		for (const control of [
+			getInputByPlaceholder(container, "Obsidian command"),
+			editorCommands,
+			getInputByPlaceholder(container, "Choice"),
+		]) {
+			getAddButtonFor(control as HTMLInputElement).click();
+		}
+
+		expect(onCommandsChange).not.toHaveBeenCalled();
+		expect(noticeClass.instances).toEqual([]);
+		expect(logError).not.toHaveBeenCalled();
+
+		editor.destroy();
+		logError.mockRestore();
+	});
+
 	it("warns when adding a user-script name that resolves to nothing", async () => {
 		const onCommandsChange = vi.fn();
 		const editor = new CommandSequenceEditor({

src/gui/MacroGUIs/CommandSequenceEditor.ts

@@ -281,6 +281,7 @@ export class CommandSequenceEditor {
 
 		const addObsidianCommandFromInput = () => {
 			const value: string = input.getValue();
+			if (!value.trim()) return;
 			const obsidianCommand = this.obsidianCommands.find((v) => v.name === value);
 
 			if (!obsidianCommand) {
@@ -319,6 +320,7 @@ export class CommandSequenceEditor {
 		let dropdownComponent: DropdownComponent;
 
 		const addEditorCommandFromDropdown = () => {
+			if (!dropdownComponent.getValue()) return;
 			const Command = editorCommands.get(dropdownComponent.getValue());
 			if (!Command) {
 				log.logError("invalid editor command type");
@@ -426,6 +428,7 @@ export class CommandSequenceEditor {
 
 		const addChoiceFromInput = () => {
 			const value: string = input.getValue();
+			if (!value.trim()) return;
 			const choice = this.choices.find((c) => c.name === value);
 			if (!choice) {
 				new Notice(`QuickAdd: No choice named "${value}".`);

tests/obsidian-stub.ts

@@ -214,6 +214,10 @@ export class DropdownComponent extends BaseComponent {
     return this;
   }
 
+  getValue(): string {
+    return this.selectEl.value;
+  }
+
   onChange(cb: (value: string) => void): this {
     this.selectEl.addEventListener("change", () => cb(this.selectEl.value));
     return this;