fix(prompts): say 1 match and 1 option in the multi-select summary - #2120
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthrough
ChangesSummary label formatting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to A count of one now uses singular wording, while larger counts remain plural. The added assertions cover option and filtered-match summaries; no concrete merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the counts with care Comment |
The multi-select and checkbox prompts' summary line now counts one in the singular:
1 matchand1 option, instead of1 matchesand1 options.Obsidian 1.13.7,
checkboxPrompt(["alpha", "beta", "gamma"])withgamtyped.Tests
searchableMultiSelect.test.ts: one option, two options, one match, two matches. It fails on master (0 selected · 1 options).pnpm run build-with-lint,pnpm run test(6602 passed),.agents/run-e2e(396 passed, 24 Templater-only skipped).Release / migration
None.
Fixes #2118
Note
Fix singular/plural wording in
SearchableMultiSelect.updateSummaryThe summary now picks singular or plural wording independently for the total option count and the filtered match count. Selected count and empty-query behavior are unchanged. Adds tests in searchableMultiSelect.test.ts covering all four count combinations.
Macroscope summarized bce3c38.
Summary by CodeRabbit