fix(one-page): show a picked note's whole name in the file picker on phones - #2112
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe phone-specific stylesheet sets a fixed width and zero padding for the one-page file-picker remove button. An end-to-end test checks that the picked note name displays and that the button is 22 pixels wide. ChangesPhone file-picker chip
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The change is narrowly scoped to phone file-picker presentation and includes targeted layout coverage. No merge-blocking issue is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the chip at night Comment |
On a phone, a note picked in the one-page form's file picker now shows its whole name. Before, the chip's × took the chip's width and the name was cut to "Ada …" or "M…". Since #2099 every one-page Capture to a folder, tag or property uses this picker.
Obsidian 1.13.7,
dev:mobile onat 390x844, a Capture toPeople/with one-page input on. Desktop is unchanged.How
Obsidian's
.is-phone .modal .setting-item-control button:not(.clickable-icon)setswidth: 100%, and.is-phone .modal .setting-item-control buttonaddspadding: 10px. Both outrank.quickAddModal .qa-onepage-file-picker__remove. One rule with the same specificity, loaded after Obsidian's, puts back the remove button's 1.4rem width and zero padding on phones.Tests
tests/e2e/one-page-capture-target.test.ts: under phone host styles, the chip shows "Mercury" uncut and the × is 22 px wide. On master it fails withcut: trueand a 62 px ×.pnpm run build-with-lint,pnpm run test(6599 passed),.agents/run-e2e(396 passed, 24 Templater-only skipped).Release / migration
None.
Fixes #2106
Note
Fix one-page file picker remove-button width on phones
Adds a phone-scoped CSS rule for the quick-add modal's selected-note remove button. It sets a fixed 1.4rem width and removes padding so the button no longer inherits the modal setting-control sizing. This frees horizontal space so the picked note's full name shows in the file picker.
Macroscope summarized db56fce.
Summary by CodeRabbit