Skip to content

fix(ui): drop the accent bar from selected rows in the multi-select picker - #2105

Merged
chhoumann merged 1 commit into
masterfrom
fix/multi-select-row-accent
Oct 1, 2026
Merged

chhoumann merged 1 commit into
masterfrom
fix/multi-select-row-accent

Conversation

@chhoumann

@chhoumann chhoumann commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

The multi-select picker ({{VALUE:a,b|multi}}, {{FILE:…|multi}}, checkboxPrompt) marked each selected row with an accent bar on the left plus row shading. The checkbox already shows the selection, so the bar was noise and doesn't match Obsidian's own lists. The shading also looked identical to hover, so a hovered row read as selected.

  • Selected rows: only the checkbox shows it.
  • Hover: unchanged.
  • Keyboard focus (ArrowDown into the list): the row gets the hover shading, and the checkbox draws its own focus ring. Before, an accent outline was drawn on :focus-within, so it also appeared after a mouse click.

Before (dark):

before

After: dark and light, mouse on the left and keyboard focus on Trinity on the right:

after

CSS only, in src/styles.css. Checked in Obsidian 1.13.7 with real key events. The multi-select and checkbox native specs pass (5/5), as do build-with-lint and the SearchableMultiSelect/MultiSuggester unit tests. No release or migration impact.

Note

Remove selected-row accent bar in the multi-select picker

Drops the selected-state background and inset accent bar from option rows in qa-searchable-multi-select in src/styles.css. Row background now also applies when a row contains a :focus-visible element, and the :focus-within outline is removed. Behavioral Change: selected rows no longer show a background or accent bar; keyboard focus is indicated by the row shading instead of an outline.

Macroscope summarized e318584.

Summary by CodeRabbit

  • Style
    • Searchable multi-select options now use the hover background when hovered or when a control inside them has keyboard focus.
    • Selected options no longer have a distinct background or accent indicator, and rows no longer display an outline when a control inside them receives focus.

…icker

The checkbox already shows what is selected, as in Obsidian's own lists.
The accent bar and the selected-row shading added noise, and the shading
looked the same as hover. Keyboard focus now shades its row like hover
instead of drawing an accent outline, which also showed after a mouse click.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T09:40:01.326991Z e318584 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5f638b6e-a17d-4358-9b24-20f3fe0b6b12

📥 Commits

Reviewing files that changed from the base of the PR and between 1da7bce and e318584.

📒 Files selected for processing (1)
  • src/styles.css

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The searchable multi-select option styles now apply the hover background when an option contains a keyboard-focused control. The selected-state background, accent inset indicator, and row-level focus outline were removed.

Changes

Option styling

Layer / File(s) Summary
Option hover and focus states
src/styles.css
The hover background also applies when an option contains a :focus-visible control. The selected-state background, accent inset indicator, and row-level :focus-within outline were removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e3185

No actionable merge-blocking issue is established. The checkbox focus-ring appearance could not be confirmed from the available repository evidence.

Architecture Summary

Architecture risk: 🔵 Low · up to e3185

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/styles.css: The option hover background now also applies when an option contains a :focus-visible control. The selected-state background and accent inset, and the row-level :focus-within outline, were removed.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main UI change: removing the accent bar from selected rows in the multi-select picker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit taps a key, then hops,
The focused row gets hover props.
The selected shade has left the scene,
No inset stripe now glows between.
I nibble CSS, pleased and neat,
Then bounce away on quiet feet.

Comment @coderabbitai help to get the list of available commands.

@chhoumann
chhoumann merged commit fcb315d into master Oct 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant