fix(ui): drop the accent bar from selected rows in the multi-select picker - #2105
Conversation
…icker The checkbox already shows what is selected, as in Obsidian's own lists. The accent bar and the selected-row shading added noise, and the shading looked the same as hover. Keyboard focus now shades its row like hover instead of drawing an accent outline, which also showed after a mouse click.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe searchable multi-select option styles now apply the hover background when an option contains a keyboard-focused control. The selected-state background, accent inset indicator, and row-level focus outline were removed. ChangesOption styling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established. The checkbox focus-ring appearance could not be confirmed from the available repository evidence. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit taps a key, then hops, Comment |
The multi-select picker (
{{VALUE:a,b|multi}},{{FILE:…|multi}},checkboxPrompt) marked each selected row with an accent bar on the left plus row shading. The checkbox already shows the selection, so the bar was noise and doesn't match Obsidian's own lists. The shading also looked identical to hover, so a hovered row read as selected.:focus-within, so it also appeared after a mouse click.Before (dark):
After: dark and light, mouse on the left and keyboard focus on Trinity on the right:
CSS only, in
src/styles.css. Checked in Obsidian 1.13.7 with real key events. The multi-select and checkbox native specs pass (5/5), as dobuild-with-lintand the SearchableMultiSelect/MultiSuggester unit tests. No release or migration impact.Note
Remove selected-row accent bar in the multi-select picker
Drops the selected-state background and inset accent bar from option rows in
qa-searchable-multi-selectin src/styles.css. Row background now also applies when a row contains a:focus-visibleelement, and the:focus-withinoutline is removed. Behavioral Change: selected rows no longer show a background or accent bar; keyboard focus is indicated by the row shading instead of an outline.Macroscope summarized e318584.
Summary by CodeRabbit