fix(file): check the note whose alias is typed as a |multi custom value - #2104
Conversation
In {{FILE:...|multi|custom}}, typing a note's alias into Add a custom
value added it as a custom row, and the alias was written as text. It
now checks that note, as the single |custom picker and remote replies
do.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughMultiSuggester now resolves typed custom values that match option aliases before it checks for duplicates or submits a selection. A test covers alias entry through Enter and Done. ChangesAlias selection
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Typed aliases now select the corresponding note rather than becoming custom text, while unmatched values retain their existing behavior. No actionable merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit taps Enter with care Comment |
Follow-up to #2102. In the in-app
{{FILE:...|multi|custom}}picker, typing a note's alias into Add a custom value added it as a custom row, and the alias was written as plain text. Typing an alias now checks that note, as an alias already does in the single|custompicker and in remote replies. Other typed text is still added as a custom value.dev:mobileObsidian 1.13.7,
{{FILE:People|multi|custom|format:markdown}},the onetyped into Add a custom value, then Enter. Thomas Anderson has the aliases Neo and The One. After pressing Done, master writes- the oneand this PR writes- Thomas Anderson.How
MultiSuggesterresolves a typed value withitemWithAlias(from #2102) in two places: when the value is added with Enter or Add, and when a draft is folded in on Done. If the note is already checked, the existing "already added" notice shows, so the note is never added twice.Tests
multiSuggester.aliases.test.ts:the oneadded with Enter andNEOfolded in on Done resolve to the note, once. It fails on master (['the one', 'NEO']).pnpm run build-with-lint,pnpm run test(6599 passed),.agents/run-e2e(395 passed, 24 Templater-only skipped).Release / migration
None.
Refs #2062
Note
Fix
MultiSuggestercustom values to resolve typed aliasesAdds a
typedValuehelper toMultiSuggesterthat resolves typed text through the configured item aliases and falls back to the original text when no alias matches. BothcommitDraft(Enter) andsubmit(Done) now canonicalize a custom-value draft through this helper before duplicate checks and selection.Macroscope summarized 52ef59c.
Summary by CodeRabbit